[MPlayer-dev-eng] text_font_scale_factor

[Vladimir Voroshilov]

Hi, Anatoli

2007/7/9, Anatoli Marinov <anatoli.marinov at gmail.com>:
> Hi guys,
> I have new version with code for property. See the atached file.
>

>+        case M_PROPERTY_SET:
>+        case M_PROPERTY_STEP_UP:
>+        case M_PROPERTY_STEP_DOWN:
>+            text_font_scale_factor += *(float *) arg;
>+            M_PROPERTY_CLAMP(prop, text_font_scale_factor);
Totally wrong. In case of M_PROPERTY_SET, you will increase scale
factor by *(float*)arg instead of setting it as new scale factor
value.


>@@ -1568,6 +1591,8 @@
>      M_OPT_RANGE, 0, 1, NULL },
>     { "sub_forced_only", mp_property_sub_forced_only, CONF_TYPE_FLAG,
>      M_OPT_RANGE, 0, 1, NULL },
>+    { "sub_scale", mp_property_sub_scale, CONF_TYPE_FLOAT,
>+     M_OPT_RANGE, 0, 10, NULL },
Here should be 100 instead of 10, IMHO (see subfont_text_scale option).

Others things looks ok.

P.S. Don't forget to modify DOCS/tech/slave.txt (as i did :( in my patch)

-- 
Regards,
Vladimir Voroshilov     mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719