[MPlayer-dev-eng] [PATCH] x11 vo drivers override user settings for window placement

[Mark Tiefenbruck]

All right, it's time to come back to this. I hope we can get down to
actual discussion of problems, with evidence, and solutions, rather
than fighting fire with fire. Not to mention completely off-topic
concerns.

You claimed you needed to force the window manager to respect your
choice because size hints weren't being respected by window managers.
Well, I've just run the command "xterm -geometry +90+90" in fluxbox,
openbox, blackbox, metacity, kwin, twm, mwm, fvwm, windowmaker, beryl,
enlightenment, sawfish, icewm, and xfwm4. Guess what my results were.
Guess what xterm uses.

If you have honestly been having trouble in this area, then there's
something wrong with your methodology. User specified geometry (e.g.
the -geometry option) should be conveyed using the USPosition and
USSize flags in the size hint. Program specified geometry should use
PPosition and PSize. And even if you have been having trouble in this
area, the appropriate course of action is to submit bug reports and
supply patches, rather than break your own software.

I noticed your recent changes to combine the window initialization for
all the different vo drivers. I applaud this effort; it was badly
needed. It does mean, however, that my patch no longer applies. This
is fine, since I've discovered a minor bug in my reasoning anyway.

You're creating the window with the specified size and position (this
is good; it's what you're supposed to do -- I just forgot) so there's
no reason to move the window at all, even if there's no window manager
running. Thus, the appropriate fix is actually just to remove the call
to vo_x11_nofs_sizepos entirely.

So, again, what's the hold-up here?

 Mark