[MPlayer-dev-eng] unrarlib still broken on 64bit

[Attila Kinali]

On Sun, 01 Jul 2007 18:56:26 -0300
Peter Cordes <peter at cordes.ca> wrote:

> --- unrarlib.h.upstream	2007-06-20 01:15:09.000000000 -0300
> +++ unrarlib.h	2007-07-01 17:33:55.192251911 -0300
> @@ -94,17 +94,11 @@
>  #endif
>  #endif
>  
> -#ifdef _WIN_32
> -typedef unsigned char    UBYTE;             /* WIN32 definitions            */
> -typedef unsigned short   UWORD;
> -typedef unsigned long    UDWORD;
> -#endif
> +#include <stdint.h>
> +typedef uint8_t  UBYTE;
> +typedef uint16_t UWORD;
> +typedef uint32_t UDWORD;
>  
> -#ifdef _UNIX                                /* LINUX/UNIX definitions       */
> -typedef unsigned char    UBYTE;
> -typedef unsigned short   UWORD;
> -typedef unsigned long    UDWORD;
> -#endif

The patch like this ins not acceptable, as IIRC 
uint8_t & co are not necessarily defined on cygwin or mingw
(one of those, don't remember which one uses a horribly
outdated gcc). But at least the unix defines can be replaced,
no have to be replaced (they are wrong this way if specific
sizes are implied in the code).
  
>  BTW, I noticed this because mplayer doesn't work with vobsubs in rar files
> on my 64bit machine, while the same subtitles still work on my x86 machine
> (both with current SVN mplayer).  My patch fixes rar vobsubs on my 64bit
> machine.
> 
>  It's a pain creating old rar files to be compatible with unrarlib, but
> I don't like wasting several MB on uncompressed subs.  (I know it's not
> much, but it bugs me.)
> 
>  7-zip would appear to be an ideal archive format for vobsubs:  it
> compresses very well (better than old compatible rar), it's fast, and is
> Free (LGPL), and there's a Free library for accessing 7z files.
> http://www.7-zip.org/sdk.html
> http://en.wikipedia.org/wiki/7z
> 

AFAIK currently only rar is supported for compression.
(Am I right? i couldnt find anything in the manpage right now
and i'm to lazy to look at the code)
IMHO this should be replaced by a plugable system that is able
to support various compression schemes, foremost gzip, pkzip
and rar (if possible also rar3 and newer).

>  But I wish AVI would just die and people would start using mkv.  (it
> compresses subs.)

I wish MKV would just die and people would start using nut. ;-)

			Attila Kinali
-- 
Praised are the Fountains of Shelieth, the silver harp of the waters,
But blest in my name forever this stream that stanched my thirst!
                         -- Deed of Morred