[MPlayer-dev-eng] [PATCH] (bit hackish) palette support for libav*

[Michael Niedermayer]

Hi

On Mon, Jan 29, 2007 at 06:22:30PM +0100, Reimar Döffinger wrote:
> Hello,
> On Mon, Jan 29, 2007 at 05:52:54PM +0100, Michael Niedermayer wrote:
> > On Mon, Jan 29, 2007 at 02:34:19PM +0100, Reimar Doeffinger wrote:
> > > attached patch fixes e.g.
> > > http://samples.mplayerhq.hu/V-codecs/KMVC/AIRSTRKE.AVI on big-endian
> > > and
> > > http://samples.mplayerhq.hu/game-formats/interplay-mve/baldursgate-camp.mve
> > > in general.
> > > Does it seems clean enough for you to be applied as-is (and yes, I
> > > noticed AVPaletteControl is deprecated and the later file probably
> > > should preferably be fixed in libavformat/libavcodec directly).
> > 
> > i refuse to accept any patch which depends on deprecated things
> > as this only increases the work for whoever removes AVPaletteControl
> 
> I don't think it would do that, it would just be dead code when
> AVPaletteControl is finally removed.
> 
> > palette changes should be sent as packets like normal frames
> 
> That might make things quite a bit simpler from the MPlayer side.
> Do you have something in mind already?
> Just adding PKT_FLAG_PALETTE and sending the palette through? Might

yes


> break if some things assume for every packet to result in a frame or so.

i doubt theres alot of such code, one i know is the timestamp guessing
code in lavf but thats a matter of a 1 line change to fix

also keep in mind that the current palette passing code does not work
if there is any delay between (lavf) demuxer and (lavc) decoder ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070129/291b19c1/attachment.pgp>