[MPlayer-dev-eng] [PATCH] (bit hackish) palette support for libav*

[Reimar Döffinger]

Hello,
On Mon, Jan 29, 2007 at 05:52:54PM +0100, Michael Niedermayer wrote:
> On Mon, Jan 29, 2007 at 02:34:19PM +0100, Reimar Doeffinger wrote:
> > attached patch fixes e.g.
> > http://samples.mplayerhq.hu/V-codecs/KMVC/AIRSTRKE.AVI on big-endian
> > and
> > http://samples.mplayerhq.hu/game-formats/interplay-mve/baldursgate-camp.mve
> > in general.
> > Does it seems clean enough for you to be applied as-is (and yes, I
> > noticed AVPaletteControl is deprecated and the later file probably
> > should preferably be fixed in libavformat/libavcodec directly).
> 
> i refuse to accept any patch which depends on deprecated things
> as this only increases the work for whoever removes AVPaletteControl

I don't think it would do that, it would just be dead code when
AVPaletteControl is finally removed.

> palette changes should be sent as packets like normal frames

That might make things quite a bit simpler from the MPlayer side.
Do you have something in mind already?
Just adding PKT_FLAG_PALETTE and sending the palette through? Might
break if some things assume for every packet to result in a frame or so.
Or alternatively adding a uint32_t *palette to AVPacket (would be NULL
if unchanged)? This would probably require the least changes compared
to current code.

Greetings,
Reimar Döffinger