[MPlayer-dev-eng] Re: [PATCH] fix "FIXME: save orig w/h, and restore if codec init failed!"

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sun Jan 28 11:37:19 CET 2007


Hello,
On Sun, Jan 28, 2007 at 11:13:19AM +0100, Reimar D?ffinger wrote:
> On Sun, Jan 28, 2007 at 03:37:53AM +0000, Compn wrote:
> > i found the files that this breaks...
> > gif demuxer does not get resolution correctly so you end up with ..
> 
> Fixed.
> 
> > also, someone uploaded some hentai animated gif samples that decode improperly 
> > with mplayer but display fine in web browser. /incoming/broken-gif/
> 
> They are broken. They specify "Disposal Method" (called refmode in
> MPlayer) as 0, about which the specification says:
> > 0 -   No disposal specified. The decoder is not required to take any action.
> 
> Which is exactly what MPlayer does. The gif instead expect it to behave
> like
> > 1 -   Do not dispose. The graphic is to be left in place.
> 
> Incidentially, the browsers behave the same for both.
> I guess I'll commit a hack to fix it anyway though.

Done.

> Now about the last non-working one:
> http://samples.mplayerhq.hu/GIF/broken-gif/splash_anim[1].gif
> This does not work in konqueror and does not animate (AFAICT) in
> firefox, so it probably is quite broken...

My fault. konqueror seems broken as far as animated gifs are concerned
(at least in my setup), and I had accidentially disabled animation in
firefox (why did they remove this setting from the settings dialog? It
was a pain to get enabled again...)
I still do not know for certain why the last one works in firefox but
not in MPlayer.

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list