[MPlayer-dev-eng] [PATCH] Improving handling of PES files

Diego Biurrun diego at biurrun.de
Sat Jan 27 15:47:33 CET 2007


On Sat, Jan 27, 2007 at 02:20:57PM +0100, Nico Sabbi wrote:
> Uoti Urpala wrote:
> >On Sat, 2007-01-27 at 13:52 +0100, Nico Sabbi wrote:
> >
> >>Loren Merritt wrote:
> >>
> >>>How would you get your prettified patch into svn log? svn invokes diff, 
> >>>regardless of how you applied your modifications.
> >>
> >>I meant svn diff.
> >>If the patch is applied prettified svn diff will be equally prettified
> >
> >Either you're not talking about the same thing or are claiming something
> >very weird. Loren's point was that hand-adjusting a patch (for the same
> >changes) is pointless since svn generates the diff it shows from the two
> >versions rather than using the diff you applied to create the changes.
> >Are you talking about something else such as changing the end result
> >(not just the patch format) to work around diff, or what?
> 
> I didn't hand adjust the patch: I applied the original one, reworked 
> the resulting code and ran svn diff against the new code.
> Is there any reason to believe that after having committed the new 
> code (let's call the new revision X) svn diff between revisions X-1 
> and X will show something != the patch I applied?

There is no reason to believe otherwise, the way you said is was,
however, ambiguous.  Therefore this misunderstanding..

Diego




More information about the MPlayer-dev-eng mailing list