[MPlayer-dev-eng] [PATCH] improve seeking in realmedia files

[Roberto Togni]

On Sat, 27 Jan 2007 16:28:24 +0800
陆然 <hephooey at gmail.com> wrote:

> Hi,
> 
> Here is a patch to improve the seeking behavior of realmedia files. It fixes 
> the time stamp after seeking by calling real_fix_timestamp(), I tested it 
> with a few files and it looks ok, meanwhile the old code is not correct 
> anyway. And the patch also call real_fix_timestamp() when it hits the first 
> fragment of a packet if it's right after seeking, this is necessary because 
> otherwise the priv->v_pts will not be updated when 
> DEMUXER_CTRL_GET_PERCENT_POS is called, currently the percentage bar in the 
> OSD does not show the right value after seeking.
> 
> BTW, the indentation in demux_real.c is terribly broken, I don't know if I 
> have done the patch according to the no cosmetics rule correctly, feel free 
> to shout out :)
> 

Can you provide some samples where this make a difference? i found only
one sample (samples/real/VC-RV40/Sample.rmvb) where seeking is totally
broken without the patch, but it works with it. But in all my tests a/v
sync was still wrong after seeking, and in both cases it fixes itself
(you can make it better with -mc 10).

The patch formatting is ok

Since i found no regressions with it i plan to apply it soon.

Ciao,
 Roberto