[MPlayer-dev-eng] [PATCH] use pthreads for caching

[A Mennucc]

Reimar Döffinger ha scritto:
> Hello,
> On Sat, Jan 27, 2007 at 10:30:30AM +0100, A Mennucc wrote:
>> So the reason that my patch for threaded caching works is that it is
>> possible to open dialog windows from different threads.
>>
>> possible solutions:
>>
>> 1) make sure you do not ever ever display a dialog from the caching code
>> 2) use pthreads
>>
>> I would suggest the 2nd  :-)
>> (as I explained in my other email, mplayer is already compiled to use
>> pthreads in linux)
> 
> 2) is not a solution to this problem it is a hack-around (or in German:
> a Würgaround).

> I think your suggestion has merits, but this problem is not one of them!

you are absolutely right.

basically, we must add some code somewhere that will not open any dialog
from the forked code. I will look into it.

Whereas opening dialogs will be OK when the cache is threaded instead of
forked:  this is useful, so the caching code can report errors on the
stream (closure of remote, underflow, blah blah) to the GUI

a.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070127/1a0ac60d/attachment.pgp>