[MPlayer-dev-eng] [PATCH] use pthreads for caching

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sat Jan 27 11:15:30 CET 2007


Hello,
On Sat, Jan 27, 2007 at 10:30:30AM +0100, A Mennucc wrote:
> So the reason that my patch for threaded caching works is that it is
> possible to open dialog windows from different threads.
> 
> possible solutions:
> 
> 1) make sure you do not ever ever display a dialog from the caching code
> 2) use pthreads
> 
> I would suggest the 2nd  :-)
> (as I explained in my other email, mplayer is already compiled to use
> pthreads in linux)

2) is not a solution to this problem it is a hack-around (or in German:
a Würgaround).
I think your suggestion has merits, but this problem is not one of them!
Actually, I consider hiding a bug a point against a patch.

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list