[MPlayer-dev-eng] [PATCH] fix "FIXME: save orig w/h, and restore if codec init failed!"

Roberto Togni rxt at rtogni.it
Fri Jan 26 21:46:19 CET 2007


On Fri, 26 Jan 2007 20:30:14 +0100
Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:

> Hello,
> attached patch fixes this FIXME. I do not know of any cases where this
> caused problems.
> Though it also fixes another inconsistency: when CODECS_FLAG_ALIGN16 is
> set, the bih values for width/height take precedence, otherwise not.
> With this consistency fix, dimensions get set correctly with
> SVQ3-over-rtsp streaming without further code changes.
> Does attached patch look okay to you? Any suggestions for
> simplification?
> 

Probably the fixme was about saving width/height only for the align16
case, but it won't hurt to always do it.

The code "looks" ok, but you just have to hope that it doesn't break
something obscure. imho apply.

Ciao,
 Roberto



More information about the MPlayer-dev-eng mailing list