[MPlayer-dev-eng] [PATCH] get rid of *void pointer arithemtic in libvo/fastmemcpy.h

Guillaume POIRIER poirierg at gmail.com
Fri Jan 26 10:10:58 CET 2007


Hi,

On 1/25/07, Rich Felker <dalias at aerifal.cx> wrote:
> On Thu, Jan 25, 2007 at 07:17:34PM +0100, Reimar Döffinger wrote:
> > > >Instead either cast or use a local variable with appropriate type IMO
> > >
> > > Attached patch implements the solution with casts, with uint8_t*.
> > >
> > > If you prefer char* or whatever else, then I can change it before
> > > committing.
> >
> > I personally prefer using (u)int8_t for arbitrary data and char* only for
> > strings, so not I don't want to change it.
> > I think it is fine, and doesn't affect readability too much. Any
> > objections?
>
> I prefer char (and generally avoiding uint*_t unless it's really
> needed), but that's just my personal preference. I don't object to
> using uint8_t if you prefer it.

Ok, so I applied it.

Guillaume


More information about the MPlayer-dev-eng mailing list