[MPlayer-dev-eng] [PATCH] don't draw osd twice in mencoder

Evgeniy Stepanov eugeni.stepanov at gmail.com
Thu Jan 25 19:38:19 CET 2007


Hi,

if "expand=::::1" filter is used with mencoder, subtitles will be rendered 
twice because the same filter is automatically appended to the end of the 
filter chain. Even worse, if there is something like "rotate" filter between 
them, image sizes used for subtitle rendering will be different. Both filters 
will in turn call vo_update_osd, the last one wins. The loser will use wrong 
coordinates in draw_osd.

This is the reason of various crashes and "green lines" with rotated 
subtitles, that are often reported in mplayer-users ML.

The patch add a new VFCTRL. Each instance of vf_expand with osd!=0 sends 
VFCTRL_DISABLE_OSD to its tail. This way, osd will be rendered by the correct 
filter (the closest to the start of the chain).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sub-single.patch
Type: text/x-diff
Size: 1247 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070125/d817bc91/attachment.patch>


More information about the MPlayer-dev-eng mailing list