[MPlayer-dev-eng] [PATCH] Libtheora encoding in lavc

[Diego Biurrun]

On Thu, Jan 25, 2007 at 01:28:37PM +0100, Guillaume POIRIER wrote:
> 
> On 1/25/07, Diego Biurrun <diego at biurrun.de> wrote:
> >On Thu, Jan 25, 2007 at 03:49:25AM -0500, Brett Goulder wrote:
> >> Fixes build with recent ffmpeg changes (libtheora-based encoding),
> >> however I have yet to make mencoder produce a stream that can be
> >> played back by the libtheora-based decoder, however ffmpeg's decoder
> >> plays the file fine. It might just be better to outright disable this
> >> for the moment, considering that it was only recently committed and
> >> seems to be somewhat incomplete.
> >
> >I've disabled this for now to hotfix the build, but maybe your patch is
> >the preferrable solution.
> >
> >So pardon my ignorance of encoding issues, but is Theora encoding over
> >lavc a desirable feature?
> 
> Desirable as an addition to our feature list, but it's likely to be
> somewhat broken.
> AFAIK, we had several bug reports about unplayable encodes when
> mencoder was using an external codec though lavc (I didn't test myself
> though).

OK, this patch will not be applied until this has been confirmed to work
then.

Diego