[MPlayer-dev-eng] [PATCH] compiling with Intel C

[Guillaume POIRIER]

Hi,

On 1/25/07, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> Hello,
> On Thu, Jan 25, 2007 at 12:39:19AM +0100, Guillaume POIRIER wrote:
> > > static uint64_t attribute_used __attribute__((aligned(8)))
> > > MM_FIX_0_382683433=FIX64(0.382683433, 14); static uint64_t attribute_used
> > > __attribute__((aligned(8))) MM_FIX_0_541196100=FIX64(0.541196100, 14);
> > >diff -ur MPlayer-1.0svn22004/loader/dmo/DMO_AudioDecoder.c
> > >MPlayer-1.0svn22004-devel/loader/dmo/DMO_AudioDecoder.c
> > >--- MPlayer-1.0svn22004/loader/dmo/DMO_AudioDecoder.c        2007-01-24
> > >18:08:55.000000000 +0300
> > >+++ MPlayer-1.0svn22004-devel/loader/dmo/DMO_AudioDecoder.c  2007-01-24
> > >17:18:31.000000000 +0300
> > >@@ -35,8 +35,6 @@
> > >
> > > #include "../../mp_msg.h"
> > >
> > >-#define __MODULE__ "DirectShow audio decoder"
> > >-
> >
> > Why ?
>
> __MODULE__ is reserved and may not be redefined in ICC. I have some
> doubts whether a C preprocessor is allowed to behave like this, but
> since I have not been able to find the point of this line (and no
> comment on my suggestion to remove them) I am in favor of getting rid of
> it...
>
> Greetings,
> Reimar Döffinger

Good, then I'd put the removal of these lines in my patch queue.

I'll submit a patch that addresses only these in a few minutes.

Guillaume