Fwd: [MPlayer-dev-eng] [PATCH] Maintain subtitles in pts order in spudec.c

Guillaume POIRIER poirierg at gmail.com
Wed Jan 24 08:20:37 CET 2007


Orgiginal message, sent month ago:

I think subtitles in spudec.c should be maintained in start_pts order.

E.g. when detecting timestamps and substreams in demux_mpg_open(), a
subtitle from near the end of the input file can be read, which
subsequently "blocks" the list -- the first packet is never taken in
spudec_heartbeat().

Alternatively, demux_mpg_open() could at its end flush the queue with
spudec_reset(), but I think the following is also very simple and
preferable, because it is also tolerant against subtitles in the wrong
order in a broken input file.

Regards,
Wolfram.

Here's Wolfram's response:

---------- Forwarded message ----------
From: Wolfram Gloger <wmglo at dent.med.uni-muenchen.de>
Date: 23 Jan 2007 10:18:00 -0000
Subject: Re: [MPlayer-dev-eng] [PATCH] Maintain subtitles in pts order
in spudec.c
To: poirierg at gmail.com
Cc: mplayer-dev-eng at mplayerhq.hu, wmglo at dent.med.uni-muenchen.de


Hi,

> An old mail I saw while cleaning up my mailbox...

Wow.  Thanks a lot for not forgetting this..

> patches are to be generated against CVS and included as attachment...

ITYM "svn" not CVS :-)   "updated" patch attached.
The patch still applies unchanged.
I have recently unsubscribed from mplayer-dev-eng, though,
so the mail may not come through there.

Regards,
Wolfram.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: spudec.diff
Type: application/octet-stream
Size: 779 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070124/4d58fa84/attachment.obj>


More information about the MPlayer-dev-eng mailing list