[MPlayer-dev-eng] Re: [PATCH] VFCTRL_PERIODIC_UPDATE
Reimar Döffinger
Reimar.Doeffinger at stud.uni-karlsruhe.de
Fri Jan 19 22:36:00 CET 2007
Hello,
On Fri, Jan 19, 2007 at 10:29:34PM +0200, Uoti Urpala wrote:
> Adding workarounds to the central timing functions is quite hackish,
> especially when it later turned out the added functionality doesn't even
> quite match what the intended use requires. I think it would have been
> better not to post VFCTRL_PERIODIC_UPDATE as a completely independent
> patch without context. A bad implementation for directly needed
> functionality is one thing and can perhaps be improved; the same for
> functionality that is meant to be used as a part of a larger hack is
> another thing.
Hm. Well, maybe it would be a good idea if you posted (or at least linked to)
the whole patch. I think Uoti wasn't around when we discussed this stuff
last time and he might have some good ideas in the areas nobody cared
about back then.
Greetings,
Reimar Döffinger
More information about the MPlayer-dev-eng
mailing list