[MPlayer-dev-eng] Re: [PATCH] VFCTRL_PERIODIC_UPDATE

[Uoti Urpala]

On Fri, 2007-01-19 at 16:42 +0100, Dirk Meyer wrote:
> Is there any chance this patch will be included into mplayer? It is
> needed for the freevo osd on top of a movie. It would help if you at
> least tell us to go away if you won't include the patch. In that case
> we won't try to get patches merged which would save us some time.

I think the patch should not be included as is. The timing-related
changes try to work around limitations that could be removed instead. A
better way would be as follows:

1) Remove the forced unpause when handling slave commands.

2) Change timing sleep to do a select on input fds instead of plain
nanosleep/usleep and process any input immediately (at least on Unix,
doing this on Windows would require more work).

If I've understood correctly what you intend to do with the overlay
filter then after those changes implementing it should be a lot more
straightforward. It could use ordinary slave commands which would remove
the need for both the input filter hacks mentioned earlier and
VFCTRL_PERIODIC_UPDATE (since the only mentioned use for the update was
basically to check input instead of any real filter functionality).

If you feel that implementing the above changes is too hard then I might
implement them myself at some point.