[MPlayer-dev-eng] [PATCH] Do not read codecs.conf files by default

[Diego Biurrun]

On Wed, Jan 17, 2007 at 12:11:36AM +0200, Ivan Kalvachev wrote:
> 2007/1/16, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> >On Mon, Jan 15, 2007 at 08:03:33PM +0100, Diego Biurrun wrote:
> >> IMO dynamic codecs.conf loading should be an optional,
> >> disabled-by-default feature that devs can compile-in if they want.
> >
> >Going that far, as Michael pointed out, would be a bad idea, among the
> >reasons security considerations.
> >A possible consideration would be to change codecs.conf in the sources
> >so that it would not load without manual modification by the user,
> >a I-know-what-I-am-doing similar to the lavf bframes thing...
> 
> There is already "release 20061022" parameter in the codecs.conf.
> If the release number is older than the one in the build-in
> codecs.conf then MPlayer should exit with error (saying "Update or
> Delete").
> 
> Of course the problem is that this release parameter is not updated on
> every commit.
> I hope we could use the svn system for that. ( if there are no $date
> like macros, then probably via pre/post-commit scripts).
> 
> I guess this would handle all cases of users stupidity and developers
> memory leaks.

It does not, look at the bug report that inspired this patch.

And I still think you guys have it backwards.  Nobody has been able to
come up with a compelling reason to keep things as they are now apart
from "It's always been like that.".

Diego