[MPlayer-dev-eng] [PATCH] Do not read codecs.conf files by default

Diego Biurrun diego at biurrun.de
Wed Jan 17 00:14:04 CET 2007


On Mon, Jan 15, 2007 at 11:09:02PM +0100, Reimar Döffinger wrote:
> On Sat, Jan 13, 2007 at 01:02:54PM +0100, Diego Biurrun wrote:
> > Index: mplayer.c
> > ===================================================================
> > --- mplayer.c	(revision 21906)
> > +++ mplayer.c	(working copy)
> > @@ -3714,15 +3714,10 @@
> >  
> >  /* Check codecs.conf. */
> >  if(!codecs_file || !parse_codec_cfg(codecs_file)){
> > -  if(!parse_codec_cfg(mem_ptr=get_path("codecs.conf"))){
> > -    if(!parse_codec_cfg(MPLAYER_CONFDIR "/codecs.conf")){
> 
> On thinking again, I suggest changing it to
> if (parse_codec_cfg(mem_ptr=get_path("codecs.conf")) ||
> parse_codec_cfg(MPLAYER_CONFDIR "/codecs.conf")) {
> printf(EEVILUSER);
> exit();
> }

:)

At first I wanted to print a warning as well, but then I thought about
why we were using codecs.conf files at all and I couldn't really come up
with a good reason..

Diego




More information about the MPlayer-dev-eng mailing list