[MPlayer-dev-eng] [PATCH] Do not read codecs.conf files by default

Diego Biurrun diego at biurrun.de
Mon Jan 15 20:03:33 CET 2007


On Mon, Jan 15, 2007 at 09:08:12AM +0100, Attila Kinali wrote:
> On Mon, 15 Jan 2007 06:40:20 +0100
> Diego Biurrun <diego at biurrun.de> wrote:
> 
> > I'll give a different reasoning: Name a reason to keep codecs.conf
> > loading from two different locations by default. 
> 
> Silently ignoring an installed config file isn't good
> practice either.

This is backwards.  If I apply my patch it's no longer a config file, so
it's not (silently) ignored.

> > Or put another way, if
> > you were starting from scratch, would you implement it that way?
> 
> I don't know. I guess i wouldn't have implemented compiled
> in codecs.conf in the first place. Yes, i know that it came
> a long time after the first implementation of codecs.conf
> and we had some reason for it back than (though i don't remember
> what it was). But also -codecs-file isn't that old, it has
> just turned 3 years old.

The fact that we have been moving further and further away from the
original codecs.conf scheme might indicate that it wasn't a good idea in
the first place..

IMO dynamic codecs.conf loading should be an optional,
disabled-by-default feature that devs can compile-in if they want.

Diego




More information about the MPlayer-dev-eng mailing list