[MPlayer-dev-eng] [PATCH] configure: Disable twolame if toolame is enabled

Dominik 'Rathann' Mierzejewski dominik at rangers.eu.org
Tue Jan 9 19:05:36 CET 2007


On Tuesday, 09 January 2007 at 18:45, Carl Eugen Hoyos wrote:
> Hi!
> 
> mencoder should not be linked to both toolame and twolame: There are multiple 
> definitions of symbols in their sourcefiles, so mencoder -oac twolame 
> crashes.
> 
> Attached patch lets autodetect never enable both libraries.
> 
> Greetings, Carl Eugen
> 

> Index: configure
> ===================================================================
> --- configure	(Revision 21858)
> +++ configure	(Arbeitskopie)
> @@ -5644,7 +5644,7 @@
>  int main(void) { twolame_init(); return 0; }
>  EOF
>    _twolame=no
> -  cc_check -ltwolame $_ld_lm && _twolame=yes
> +  cc_check -ltwolame $_ld_lm && _twolame=yes && test "$_toolame" = yes && _res_comment="disabled by toolame" && _twolame=no
>  fi
>  if test "$_twolame" = yes ; then
>    _def_twolame='#define HAVE_TWOLAME 1'

Actually it should be the other way around, i.e. twolame should disable
toolame, because it's at least maintained, while toolame is not.

Regards,
R.

-- 
MPlayer developer and RPMs maintainer: http://mplayerhq.hu http://rpm.livna.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan



More information about the MPlayer-dev-eng mailing list