[MPlayer-dev-eng] [patch] slow menus

[Dominik 'Rathann' Mierzejewski]

On Sunday, 07 January 2007 at 13:26, Adam Sulmicki wrote:
[...]
> can folks review it for correctness?
> 
> I would be curious how it works for other people who use -dr and menus.
> 
> This is the patch, but without any identation
> 
> 	http://www.missl.cs.umd.edu/~adam/mplayer.slow-menu.basic.diff
> 
> Same as above but with indentation
> 
> 	http://www.missl.cs.umd.edu/~adam/mplayer.slow-menu.diff

http://www.mplayerhq.hu/DOCS/tech/patches.txt
[...]
 5. Read your patch. We'll *refuse* it if it changes indentation of the
    code or if it does tab/space conversion or other cosmetic changes!

Your patch still contains a cosmetic change, i.e. this:
-  } else {
+  } else { // show=0
+

[...]
 9. Send your patch to the mplayer-dev-eng mailing list as a base64-encoded
    attachment with the subject line:
    '[PATCH] very short description of the patch'.
    In the mail, describe in a few sentences what you change and why.

You haven't attached it to your message. I know all these rules may seem
unimportant and trivial to you, but please bear with us.

Regards,
R.

-- 
MPlayer developer and RPMs maintainer: http://mplayerhq.hu http://rpm.livna.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan