[MPlayer-dev-eng] [PATCH] some muxer_lavf mess cleanup

[Reimar Döffinger]

Hello,
On Fri, Jan 05, 2007 at 11:43:47PM +0100, Michael Niedermayer wrote:
> On Fri, Jan 05, 2007 at 04:55:16PM +0100, Reimar Döffinger wrote:
> [...]
> > > that brings us to the point that you have to fix ae_lavc.c too
> > 
> > "have"? 
> 
> yes, its highly unlikely that you would fix just a subset of the
> files which you know are affected by the same bug :)

Damn, now everyone knows how to trick me into fixing bugs. I have to be
more careful ;-)

> > I have a new patch that fixes both muxer_lavf and ae_lavc. But I have to
> > say that I really do not dynamic lib handling.
> > Since MPlayer checkout always includes the libavf dirs I am tempted to
> > just always #include "libavformat/riff.h", even if this increases the
> > risks of incompatibilities even further...
> > What do you think?
> 
> i think its ok, and btw, i think you can just commit such simple fixes to
> files i maintain without having to post patches before, i trust you to
> not break anything, at least not more then i do ...

Thanks, applied the patch. Sending a patch also means waiting a bit and
think before applying which I find useful regardless though ;-)
So assuming I understood you correctly I will replace the current fix with
#include "libavformat/riff.h" unconditionally.

Greetings,
Reimar Döffinger