[MPlayer-dev-eng] [RFC] subtitle cleanup

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sat Jan 6 11:37:59 CET 2007


Hello,
On Sat, Jan 06, 2007 at 11:36:36AM +0100, Reimar D?ffinger wrote:
> On Fri, Jan 05, 2007 at 05:49:56PM +0100, Reimar D?ffinger wrote:
> > On Thu, Dec 21, 2006 at 11:26:23PM +0100, Reimar D?ffinger wrote:
> > > On Thu, Dec 21, 2006 at 07:19:47PM +0100, Reimar D?ffinger wrote:
> > > > attached patch moves subtitle stuff (only mov for now) to mplayer.c.
> > > > Biggest problem right now is that it breaks vobsubs embedded in mp4
> > > > (http://samples.mplayerhq.hu/sub/NeroMP4/unsupported-embedded-subs-2.mp4),
> > > > it seems that the vobsub code ignores pts values or something like
> > > > this...
> > > 
> > > Improved version with less code in mplayer.c and a lot of code in
> > > demux_mkv.c replaced by shared code in sub.c.
> > 
> > An update that hopefully encompasses most remarks made.
> 
> Another try with some fixes and cleanup to the mkv code.

And here is the actual patch. I'd like to apply soon, so it is easier to
do further necessary cleanups.

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list