[MPlayer-dev-eng] [PATCH] Fix --enable-runtime-cpudetection under MinGW

[Reimar Döffinger]

Hello,
On Fri, Jan 05, 2007 at 10:50:40PM +0100, Bj?rn Sandell wrote:
> On Fri, 5 Jan 2007 21:35:51 +0100
> Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> > Oh, I see. But since this problem does not affect e.g. AMD64 and also
> > runtime cpudetection AFAIK will not support 386 anyway, I suggest
> > something like this instead:
> > 
> > Index: configure
> > ===================================================================
> > --- configure   (revision 21828)
> > +++ configure   (working copy)
> > @@ -886,6 +887,8 @@
> >    _target_arch_x86="TARGET_ARCH_X86 = yes"
> >    _def_arch="#define ARCH_X86_32 1"
> >    _target_arch="TARGET_ARCH_X86_32 = yes"
> > +  iproc=486
> > +  proc=i486
> 
> Well, the reason for choosing 386 was that the only use of __CPU__ I
> found was
> 
> #if __CPU__ != 386
> 
> so 386 seemed as safe way to go. If you choose anything else as default
> I would suggest "Unknown" as we might be dealing with a ppc. For this
> reason I also suspect that it would safer to leave "proc" alone.
> (someone with a ppc could easily test this :)

This problem does not affect PPC, it correctly set iproc to iproc='ppc'
by default. My proposal just adds such a default for the x86_32 case.

Greetings,
Reimar Döffinger