[MPlayer-dev-eng] [PATCH] some muxer_lavf mess cleanup

[Michael Niedermayer]

Hi

On Fri, Jan 05, 2007 at 11:31:33AM +0100, Reimar Döffinger wrote:
> Hello,
> attached patch does:
> 1) include the proper header (riff.h) instead of adding our own function
> prototypes for all those functions

ok of course


> 2) add missing prototype for codec_get_id and CodecTag typedef

ok of course


> 3) remove useless extern for function prototypes

ok of course


> 4) mp_wav_tags is of type CodecTag[] not int[]!!! Lazyness is not an
> excuse for that kind of hacks

oops, thats a little embarassing but it was not exactly lazyness but rather
limitless stupidity ... when the compiler didnt like CodecTag i thought it was
just a typdef int with fourcc in it (of course thats not possible and i should
have remembered my own code ...) and as its used for example in 
libmpcodecs/ae_lavc.c which shouldnt depend on headers from lavf i thought
cheating and using int would do ...

that brings us to the point that you have to fix ae_lavc.c too


> 5) sizeof() is of type long, thus %d is the wrong printf format. Though
> I suggest fixing by setting first ctx->extradata_size, thus also
> avoiding some code duplication.

ok


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070105/bafa89fd/attachment.pgp>