[MPlayer-dev-eng] PATCH [4/12] CoreAVC support (Take 3)

[Baptiste Coudurier]

Hi

Reimar Döffinger wrote:
> Hello,
> On Tue, Feb 27, 2007 at 12:41:48PM -0800, Alan Nisota wrote:
>>> 004avc1mov.patch: allow both 'avc1' and 'AVC1' streams to be processed
> 
>> Index: libmpdemux/demux_mov.c
>> ===================================================================
>> --- libmpdemux/demux_mov.c.orig	2007-02-15 09:42:47.000000000 -0800
>> +++ libmpdemux/demux_mov.c	2007-02-15 09:43:25.000000000 -0800
>> @@ -1267,7 +1267,8 @@
>>  		}
>>  		else
>>  		{
>> -		 if (trak->fourcc == mmioFOURCC('a','v','c','1')) {
>> +		 if (trak->fourcc == mmioFOURCC('a','v','c','1') ||
>> +                     trak->fourcc == mmioFOURCC('A','V','C','1')) {
>>  		  if (trak->stream_header_len > 0xffffffff - sizeof(BITMAPINFOHEADER)) {
>>  		    mp_msg(MSGT_DEMUXER, MSGL_ERR, "Invalid extradata size %d, skipping\n",trak->stream_header_len);
>>  		    trak->stream_header_len = 0;
> 
> This seems wrong, since avc1 is supposed to be the only correct code for it.
> Can you upload a sample? libavformat should probably changed, too (see
> attached patch), am I right that -demuxer lavf works with this patch and
> does not without?
> 

You know how picky I am about codec_id/tags.

It should not be needed, lavf uses codec_get_id which according to the
code should match both case, also lavf mov demuxer fallback on riff tags
when it fails to find in mov tags, and yes this tag is wrong.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312