[MPlayer-dev-eng] [PATCH] cleaning up r22297:22298

Uoti Urpala uoti.urpala at pp1.inet.fi
Wed Feb 28 07:18:49 CET 2007

On Sun, 2007-02-25 at 22:59 +0100, Dominik 'Rathann' Mierzejewski wrote:
> Here's what I intend to do:
> svn rm command.c
> svn update -r22297 mplayer.c
> svn cp mplayer.c command.c
> patch command.c mplayer.c-command.c.patch
> svn update mplayer.c
> svn commit command.c
> The attached patch is almost the same as the one I posted earlier, but it

There's one problem with the resulting command.c: because of the
reordering of the includes string.h (which isn't included explicitly in
either version) does not get included early enough. It's best to add an
explicit include for it of course.

After fixing that the functionality seems to match the current
command.c. For some reason it still doesn't compile to exactly identical
code, but the only difference seems to be an inverted test and
corresponding conditional jump.

With that fix I'm OK with the change. I won't try committing it myself
now as I haven't had nearly enough sleep.

More information about the MPlayer-dev-eng mailing list