[MPlayer-dev-eng] [PATCH] Fix for wma9spdshow binary audio coder loading

[Vladimir Voroshilov]

2007/2/21, Vladimir Voroshilov <voroshil at gmail.com>:
> 2007/2/21, Roberto Togni <rxt at rtogni.it>:
> > On Wed, 21 Feb 2007 02:10:22 +0600
> > "Vladimir Voroshilov" <voroshil at gmail.com> wrote:
> >
> > > With attached (a little hackish) patch (must be applyed after  VoxWare
> > > related Bugzilla bug #16 patch, will be commited soon) Windows Media
> > > Audio 9 Speech DShow audio codec works for me.
> > > All samples from http://samples.mplayerhq.hu/A-codecs/WMSP/ were tested.
> > > Under mingw all samples are played fine.
> > > Under Linux samples marked as "-7K" and "-11K" are played with
> > > repeating hissing.
> > >
> > > P.S. WMAVDS32.ax is needed for codec to work (should be put into
> > > essentials package, i think). File was provided by Compn to me.
> > >
> > > Opinions are welcome.
> > > I am planning to commit this and VoxWare related patch in two days.
> > >
> >
> > Do the dmo decoder for wmsp works on window?
> > How hackish do you consider this patch?
> 1 small hack: call to MemAllocator only for RegisterComObject
> 2 small hack: disagree with suggested buffer size=2 and replace it
> with 10K buffer.
> this does not go agains Directshow docs. Docs says that allocator can
> disagree with suggested buffer size and can set it's own preferable
> value.
>
> >
> > If(dmo_works && very_hackish) do not commit; else commit;
> You can see patch: 4 lines is changed. This is not big hack for me.
> What about you?
Merged and applied with VoxWare patch.

> > btw where is tempAll used?
> tempAll is used only in "tempAll->vt->Release(tempAll)", to avoid memory leak :)
> It is needed to call to MemAllocatorCreate to make sure that
> RegisterComOject(CLSID_MemAllocator) will be called before call to
> m_pOutOutput->ReceiveConnection, otherwise WMSP will not start under
> Linux.
Aproperiate comment added to source code

-- 
Regards,
Vladimir Voroshilov     mailto:voroshil at gmail.com
JID: voroshil at jabber.ru
ICQ: 95587719