[MPlayer-dev-eng] GUI

Uoti Urpala uoti.urpala at pp1.inet.fi
Wed Feb 21 11:27:46 CET 2007

On Wed, 2007-02-21 at 08:45 +0100, Jindrich Makovicka wrote:
> On 2/21/07, Uoti Urpala <uoti.urpala at pp1.inet.fi> wrote:
> > The GUI is currently broken after the mplayer.c changes. I'm hoping that
> > someone else will fix it. If no one does within a couple of days I'll
> > hack it enough to make it compile.
> >
> > I think the preferred way to fix it would be to change the global
> > variable accesses to use the command/property interface instead,
> > extending/improving that if necessary.
> Note that libmenu is also broken due to m_property changes.

It seems to fail for the same 2 reasons the GUI does: the property
functions need an MPContext pointer now, and it tries to use global
state variables some of which have been removed.

To fix the first one they need to be told about the MPContext pointer to
use. The second could be fixed either by accessing the variables under
MPContext (as corresponding variables still exist at least for now) or
by using a different API. I think the GUI shouldn't depend on all the
internal variables it now does or it'll break again in the future, but
libmenu doesn't seem as bad. I'll try to fix it later today.

More information about the MPlayer-dev-eng mailing list