[MPlayer-dev-eng] [PATCH] avoid useless full xvmc reinit with -fixed-vo if possible
Reimar.Doeffinger at stud.uni-karlsruhe.de
Mon Feb 19 16:08:24 CET 2007
On Mon, Feb 19, 2007 at 04:01:06PM +0100, Reimar D?ffinger wrote:
> On Mon, Feb 19, 2007 at 02:46:15PM +0200, Ivan Kalvachev wrote:
> > Anyway. There is something mode fundamentally wrong in your patch. If
> > you had tested it with -loop 10 -fixed-vo, you'd quite easy would get
> > an abort(), due to surface deprivation.
> Um, I actually tested with -loop 0 (and of course -fixed-vo), but even
> after about 30 "reinits" there was no problem.
> No I readily believe the code was buggy, but a lack of testing was not
> to blame for it.
Maybe that was because the patch I mostly tested and applied did skip
> /* store image dimesions for displaying */
> p_render_surface_visible = NULL;
> p_render_surface_to_show = NULL;
> free_element = 0;
> first_frame = 1;
Well, doesn't matter anymore anyway *g*
More information about the MPlayer-dev-eng