[MPlayer-dev-eng] [PATCH] aspect ratio change in vd_ffmpeg.c
michaelni at gmx.at
Mon Feb 19 00:13:23 CET 2007
On Sun, Feb 18, 2007 at 11:42:27PM +0100, Carl Eugen Hoyos wrote:
> Hi Michael!
> On 2007-02-18 12:51, Michael Niedermayer wrote:
> > > Nico showed me an old patch to allow aspect ratio changes in vd_ffmpeg.c
> > > yesterday on irc. I had to add rint() so the compare (aspect vs
> > > last_aspect) doesn't fail for every frame.
> > >
> > > Aspect ratio change is very important for watching dvb (but only
> > > supported for -vc mpeg12 atm), so please consider.
> > >
> > > Please review, Carl Eugen
> > i am against rint() this is ugly, rather store the AVRational
> > avctx->sample_aspect_ratio in a AVRational last_aspect
> Thanks for reviewing, new patch attached.
the patch is ok
but last_aspect and these outcommented lines should be removed
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: not available
More information about the MPlayer-dev-eng