[MPlayer-dev-eng] [PATCH] avoid useless full xvmc reinit with -fixed-vo if possible

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sun Feb 18 14:37:52 CET 2007


Hello,
On Sun, Feb 18, 2007 at 01:41:38PM +0100, Michael Niedermayer wrote:
> On Sun, Feb 18, 2007 at 01:03:19PM +0100, Reimar Döffinger wrote:
> [...]
> > > Revert Immediately, using svn copy method, and I'd pretend that this
> > > have never happened.
> > 
> > I am not too interested in pretensions, so at the risk of annoying you
> > endlessly I'd still like to suggest attached patch.
> > I does have the advantage of having why previous version was a bad idea
> > in svn log...
> > Also my reading of svn-howto was hat svn copy was to be used for
> > earth-shattering-stupid commits, so I would like it someone would risk
> > his neck by commenting on the way of reverting it.
> 
> IMO if in doubt use svn copy method to revert :))))))

After having another look at it I agree.
I nevertheless stand my attempt to suggest a fix before resorting to reverting,
it doesn't cause breakage and no changes are planned on the files
affected AFAIK, so can still be safely reverted in a few hours.
I hope the patch gets a reply, if not I will revert tonight.

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list