[MPlayer-dev-eng] [PATCH] avoid useless full xvmc reinit with -fixed-vo if possible

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sun Feb 18 11:39:55 CET 2007

On Sun, Feb 18, 2007 at 12:18:30PM +0200, Ivan Kalvachev wrote:
> 2007/2/18, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> >On Wed, Feb 14, 2007 at 03:25:05PM +0100, Reimar D?ffinger wrote:
> >> if the source format remains unchanged there is no need to reinit the
> >> hardware, buffers etc. which with xvmc in addition causes several blue
> >> frames.
> >> I added a voflag to indicate this condition because I think other vos
> >> can make use of it as well.
> >> Unfortunately config() can not be completely skipped because the
> >> geometry stuff is config() - which btw. I'd like to change as there is a
> >> massive code duplication with nearly every vo using the same code.
> >
> >Applied a version adapted to recent changes.
> Revert Immediately.

If your last mail is the only objections you have, doesn't it make more
sense to just move the check from video_out.c to vo_xvmc.c instead of
reverting all of it?
Even if we wouldn't want the functionality, I think having split the
config() function doesn't hurt...

Reimar Döffinger

More information about the MPlayer-dev-eng mailing list