[MPlayer-dev-eng] [PATCH] avoid useless full xvmc reinit with -fixed-vo if possible

[Reimar Döffinger]

Hello,
On Sun, Feb 18, 2007 at 12:16:40PM +0200, Ivan Kalvachev wrote:
> 2007/2/18, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> >Making this entirely internal to the vo would mean duplicating the code
> >for each. But I will update the patch to make the needed changes in
> >video_out.c instead of vf_vo.c
> 
> I don't like it, either.
> The thing is that the vo already knows and stores the dimensions.
> Instead of making check by itself, the vo checks for flag that is set
> by vf_vo.c.
> I'm trying to say that instead of duplicating:
> 
> if (vo_width==width && vo_height==height && vo_fmt==pix_fmt)
> 
> we would be duplicating
> 
> if (!(flags & VOFLAG_SAME_INPUT))
> 
> The difference is that in the second case we have
> + 3 new variables

3 new variables in video_out.c, in the former case 3 new variables in
each vo that supports it.

> + new code to update and compare these variable

Needed in the first case, too, or do you have in mind something
completely different?

> + new flag.

True.

Greetings,
Reimar Döffinger