[MPlayer-dev-eng] [PATCH] minor cosmetic stream_dvd.c simplification
Reimar Döffinger
Reimar.Doeffinger at stud.uni-karlsruhe.de
Thu Feb 15 13:46:55 CET 2007
Hello,
I know the compiler can do common subexpression elimination, but I
always find it good when the source code is easier to read than the
compiled one.
Having at least some lines shorter than 80 characters really helps I
think...
I intend to apply soon if noone objects.
I also found some stupidity: the audio channel "checking" code tests for
if(vts_file->vts_pgcit) != 0, but this is pointless since the equivalent
subtitle code does not. Probably it can simply be removed...
Greetings,
Reimar Döffinger
-------------- next part --------------
Index: stream/stream_dvd.c
===================================================================
--- stream/stream_dvd.c (revision 22221)
+++ stream/stream_dvd.c (working copy)
@@ -786,6 +786,7 @@
ifo_handle_t *vmg_file;
tt_srpt_t *tt_srpt;
ifo_handle_t *vts_file;
+ pgc_t *pgc;
/**
* Open the disc.
*/
@@ -920,6 +921,7 @@
--dvd_angle; // remap 1.. -> 0..
ttn = tt_srpt->title[dvd_title].vts_ttn - 1;
+ pgc = vts_file->vts_pgcit ? vts_file->vts_pgcit->pgci_srp[ttn].pgc : NULL;
/**
* Load the VTS information for the title set our title is in.
*/
@@ -963,13 +965,14 @@
int i;
for(i=0;i<8;i++)
#ifdef USE_DVDREAD_INTERNAL
- if(vts_file->vts_pgcit->pgci_srp[ttn].pgc->audio_control[i].present) {
+ if(pgc->audio_control[i].present) {
#else
- if(vts_file->vts_pgcit->pgci_srp[ttn].pgc->audio_control[i] & 0x8000) {
+ if(pgc->audio_control[i] & 0x8000) {
#endif
audio_attr_t * audio = &vts_file->vtsi_mat->vts_audio_attr[i];
int language = 0;
char tmp[] = "unknown";
+ stream_language_t *audio_stream = &d->audio_streams[d->nr_of_channels];
if(audio->lang_type == 1) {
language=audio->lang_code;
@@ -978,43 +981,43 @@
tmp[2]=0;
}
- d->audio_streams[d->nr_of_channels].language=language;
+ audio_stream->language=language;
#ifdef USE_DVDREAD_INTERNAL
- d->audio_streams[d->nr_of_channels].id=vts_file->vts_pgcit->pgci_srp[ttn].pgc->audio_control[i].s_audio;
+ audio_stream->id=pgc->audio_control[i].s_audio;
#else
- d->audio_streams[d->nr_of_channels].id=vts_file->vts_pgcit->pgci_srp[ttn].pgc->audio_control[i] >> 8 & 7;
+ audio_stream->id=pgc->audio_control[i] >> 8 & 7;
#endif
switch(audio->audio_format) {
case 0: // ac3
- d->audio_streams[d->nr_of_channels].id+=FIRST_AC3_AID;
+ audio_stream->id+=FIRST_AC3_AID;
break;
case 6: // dts
- d->audio_streams[d->nr_of_channels].id+=FIRST_DTS_AID;
+ audio_stream->id+=FIRST_DTS_AID;
break;
case 2: // mpeg layer 1/2/3
case 3: // mpeg2 ext
- d->audio_streams[d->nr_of_channels].id+=FIRST_MPG_AID;
+ audio_stream->id+=FIRST_MPG_AID;
break;
case 4: // lpcm
- d->audio_streams[d->nr_of_channels].id+=FIRST_PCM_AID;
+ audio_stream->id+=FIRST_PCM_AID;
break;
}
- d->audio_streams[d->nr_of_channels].type=audio->audio_format;
+ audio_stream->type=audio->audio_format;
// Pontscho: to my mind, tha channels:
// 1 - stereo
// 5 - 5.1
- d->audio_streams[d->nr_of_channels].channels=audio->channels;
+ audio_stream->channels=audio->channels;
mp_msg(MSGT_OPEN,MSGL_STATUS,MSGTR_DVDaudioStreamInfo,
d->nr_of_channels,
dvd_audio_stream_types[ audio->audio_format ],
dvd_audio_stream_channels[ audio->channels ],
tmp,
- d->audio_streams[d->nr_of_channels].id
+ audio_stream->id
);
- mp_msg(MSGT_IDENTIFY, MSGL_INFO, "ID_AUDIO_ID=%d\n", d->audio_streams[d->nr_of_channels].id);
+ mp_msg(MSGT_IDENTIFY, MSGL_INFO, "ID_AUDIO_ID=%d\n", audio_stream->id);
if(language && tmp[0])
- mp_msg(MSGT_IDENTIFY, MSGL_INFO, "ID_AID_%d_LANG=%s\n", d->audio_streams[d->nr_of_channels].id, tmp);
+ mp_msg(MSGT_IDENTIFY, MSGL_INFO, "ID_AID_%d_LANG=%s\n", audio_stream->id, tmp);
d->nr_of_channels++;
}
@@ -1031,14 +1034,15 @@
d->nr_of_subtitles=0;
for(i=0;i<32;i++)
#ifdef USE_DVDREAD_INTERNAL
- if(vts_file->vts_pgcit->pgci_srp[ttn].pgc->subp_control[i].present) {
+ if(pgc->subp_control[i].present) {
#else
- if(vts_file->vts_pgcit->pgci_srp[ttn].pgc->subp_control[i] & 0x80000000) {
+ if(pgc->subp_control[i] & 0x80000000) {
#endif
subp_attr_t * subtitle = &vts_file->vtsi_mat->vts_subp_attr[i];
video_attr_t *video = &vts_file->vtsi_mat->vts_video_attr;
int language = 0;
char tmp[] = "unknown";
+ stream_language_t *sub_stream = &d->subtitles[d->nr_of_subtitles];
if(subtitle->type == 1) {
language=subtitle->lang_code;
@@ -1047,19 +1051,19 @@
tmp[2]=0;
}
- d->subtitles[ d->nr_of_subtitles ].language=language;
- d->subtitles[ d->nr_of_subtitles ].id=d->nr_of_subtitles;
+ sub_stream->language=language;
+ sub_stream->id=d->nr_of_subtitles;
if(video->display_aspect_ratio == 0) /* 4:3 */
#ifdef USE_DVDREAD_INTERNAL
- d->subtitles[d->nr_of_subtitles].id = vts_file->vts_pgcit->pgci_srp[ttn].pgc->subp_control[i].s_4p3;
+ sub_stream->id = pgc->subp_control[i].s_4p3;
#else
- d->subtitles[d->nr_of_subtitles].id = vts_file->vts_pgcit->pgci_srp[ttn].pgc->subp_control[i] >> 24 & 31;
+ sub_stream->id = pgc->subp_control[i] >> 24 & 31;
#endif
else if(video->display_aspect_ratio == 3) /* 16:9 */
#ifdef USE_DVDREAD_INTERNAL
- d->subtitles[d->nr_of_subtitles].id = vts_file->vts_pgcit->pgci_srp[ttn].pgc->subp_control[i].s_lbox;
+ sub_stream->id = pgc->subp_control[i].s_lbox;
#else
- d->subtitles[d->nr_of_subtitles].id = vts_file->vts_pgcit->pgci_srp[ttn].pgc->subp_control[i] >> 8 & 31;
+ sub_stream->id = pgc->subp_control[i] >> 8 & 31;
#endif
mp_msg(MSGT_OPEN,MSGL_STATUS,MSGTR_DVDsubtitleLanguage, d->nr_of_subtitles, tmp);
More information about the MPlayer-dev-eng
mailing list