[MPlayer-dev-eng] Re: [PATCH] AM_MEDIA_TYPE related utils

[Vladimir Voroshilov]

2007/2/11, Vladimir Voroshilov <voroshil at gmail.com>:
> 2007/2/11, Alan Nisota <alannisota at gmail.com>:
> > Vladimir Voroshilov <voroshil <at> gmail.com> writes:
> >
> > > Anyway i have prepared wine based version.
> > > What will you say about it?
> > > What will say another devs?
> > >
> > > Well, please anybody also tell me what to do with licence notice. And
> > > which license should we use? GPL or LGPL?
> > You can change the license to be GPL in accordance with the rest of mplayer
> > (LGPL allows that).  Also, you should, in my opinion, maintain the copyright of
> > the original author in the header.  It is only fair when using other's code.
> Ok. This is the same patch with appended GPL license notice as well as
> the author of original code.
>
> > I can't really comment on the code any further though.
> What will say another devs?
>
Just to add another vote for patch.
Investigation shows that messed up CoTaskMemAlloc/memalloc and
CoTaskMemFree/free causes MPlayer to crash periodically under win32
with tv://.  When i replaced all malloc() and free() related to
AM_MEDIA_TYPE with CoTaskMemAlloc() and CoTaskMemFree() crashes are
gone away.

P.S. probably i should put mediatype.c to loader/dshow/ and not to loader/

-- 
Regards,
Vladimir Voroshilov     mailto:voroshil at gmail.com
JID: voroshil at jabber.ru
ICQ: 95587719