[MPlayer-dev-eng] Re: [PATCH] dvr-ms fixes for pts, key frame detection and seeking

[Rich Felker]

On Fri, Feb 09, 2007 at 01:02:43AM +0200, Uoti Urpala wrote:
> On Thu, 2007-02-08 at 17:35 -0500, Rich Felker wrote:
> > Perhaps where all of this is going is hilighting the fact the MPlayer
> > _needs_ to use "framers"/AVParser with broken containers. The
> > interface for using them should probably be made generic rather than
> > putting it in particular demuxers, though. That way everything could
> > get fixed at once: dvr-ms, "laced" ogg and mkv, etc...
> 
> What is there to "fix" for laced mkv? Lacing audio packets with a
> timestamp only for the first one does not cause any problems for
> playback.

By this same argument, omitting all timestamps for audio doesn't cause
any problem because you can just start from the beginning and count
samples... Obviously this is nonsense though. Having correct
timestamps is requisite for frame-precise seeking and in general it
will simplify the "correct pts" overhaul of the playback loop if all
frames have timestamps, rather than just some random subset having
timestamps. Also...

> It could complicate things if you try to remux into a
> container which is unable to handle such streams, but given MEncoder's
> current state that's not too relevant.

...MEncoder will never work if we keep the attitude of not fixing
problems because MEncoder is broken anyway. Originally you were the
one working to fix the broken system and use pts correctly (that's why
I supported you becoming a developer, IIRC) and I'd be happy to see
you continue in that direction.

Rich