[MPlayer-dev-eng] [PATCH] clean/update subtitles on seek

[Reimar Döffinger]

Hello,
On Thu, Feb 08, 2007 at 02:50:52PM +0100, Herv? W. wrote:
> On 08/02/07, Reimar Döffinger wrote:
> >On Thu, Feb 08, 2007 at 02:02:06PM +0100, Guillaume POIRIER wrote:
> >> On 2/8/07, Reimar Döffinger wrote:
> >>
> 
> [...]
> 
> >> Also, there's another problem that I noticed: subs sometimes stay on
> >> screen when you're seeking.
> >>
> >> So, what should I expect?
> >
> >The later problem should disappear.
> 
> Is this at all related to subtitles staying in picture until the next
> overwrites them after you've encoded them into your new videofile with
> mencoder?

No. Currently at least embedded subs do not work at all with mencoder.
If you use that feature you might want to test with my [RFC] patch to
check for regressions.
You can also test if this patch helps:

Index: libmpcodecs/vf_expand.c
===================================================================
--- libmpcodecs/vf_expand.c     (revision 22173)
+++ libmpcodecs/vf_expand.c     (working copy)
@@ -224,6 +224,7 @@
 //    if(mpi->type==MP_IMGTYPE_IPB) return; // not yet working
 #ifdef OSD_SUPPORT
     if(vf->priv->osd && (mpi->flags&MP_IMGFLAG_PRESERVE)){
+        return;
        // check if we have to render osd!
        vo_update_osd(vf->priv->exp_w, vf->priv->exp_h);
        if(vo_osd_check_range_update(vf->priv->exp_x,vf->priv->exp_y,

Greetings,
Reimar Döffinger