[MPlayer-dev-eng] [PATCH] allow using commas in list options

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Wed Feb 7 19:49:15 CET 2007


Hello,
On Wed, Feb 07, 2007 at 08:31:23PM +0200, Ivan Kalvachev wrote:
> 2007/2/7, Gene Pavlovsky <heilong at bluebottle.com>:
> >I'm new to this list; my previous e-mail about this patch got ignored. Did 
> >I do smth wrong?
> >
> >Here's a patch against MPlayer-1.0rc1 to fix this bug
> >http://bugzilla.mplayerhq.hu/show_bug.cgi?id=378
> >With the current version of mplayer, it's not possible to output files (-ao
> >pcm:file=filename) containing commas, because mplayer's option parser 
> >strips
> >the commas away. This patch makes it possible to produce files with commas 
> >by
> >escaping (backslashing) the commas in the filename.
> >
> ># mplayer 01-a,b.mp3 -ao pcm:file='01-a\,b.wav'
> 
> How does it work under windows?
> You know, they use that backslash as directory separator.

I already applied a patch with this functionality, since there was such
escaping functionality already added in this file because of -vf geq.
It should not cause any too bad problems though, since all it does is
replace a \, sequence by ,.
This has only two "bad" effects on windows:
1) if you mean the file ",b.wav" in the "01-a" directory you have to
write '01-a\\,b.wav' - should not be a problem since this would not
have worked at all before
2) if you need to specify a directory you must either put it last or not
append a \

I also think that / is supposed to work fine as directory separator on
windows...

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list