[MPlayer-dev-eng] [PATCH] fix a few warnings
Reimar.Doeffinger at stud.uni-karlsruhe.de
Tue Feb 6 14:34:44 CET 2007
On Tue, Feb 06, 2007 at 12:50:16AM +0100, Dominik 'Rathann' Mierzejewski wrote:
> - mp_msg(MSGT_DEMUX, MSGL_ERR, "Invalid cmvd atom size %d\n", moov_sz);
> + mp_msg(MSGT_DEMUX, MSGL_ERR, "Invalid cmvd atom size %ld\n", moov_sz);
%ld is not the correct format string for size_t, there actually is no
portable one for it AFAIK.
I personally find that patch also a bit overkill for one warning, that
in addition only appears on 64 bit architectures...
A quicker fix would probably be to just cast to size_t in the if, I'd
expect gcc to be too stupid to understand that. But it's still an ugly
hack just to remove one warning - I'm sure there are warnings and other
stuff that are more worth the effort.
More information about the MPlayer-dev-eng