[MPlayer-dev-eng] [PATCH] Fw: [Bug 673] New: Network timeout

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Fri Feb 2 23:46:03 CET 2007


Hello,
On Fri, Feb 02, 2007 at 11:33:25PM +0100, Roberto Togni wrote:
> On Sat, 16 Dec 2006 00:54:35 +0100
> Roberto Togni <rxt at rtogni.it> wrote:
> > Got this from bugzilla, can anybody comment on the patch, expecially
> > about portability to non-linux systems?
> > Patch is untested by me, if the solution is ok I'll rework it.
> 
> The tcp part fixes hanging forever on this stream
> mms://live.sc2.org:13334 (warning: temporary url, may be dead when you
> read this), I'll apply it soon if nobody complains.
> 
> I'm not sure if the error checking (perror) is useful, reimar thinks it
> could be omitted.

At least perror is not a good idea. And a proper mp_msg just does not
seem worth it to me.
And if you apply please remove the useless () around the defined()
checks.

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list