[MPlayer-dev-eng] cruft in liba52/
Diego Biurrun
diego at biurrun.de
Mon Dec 31 00:21:32 CET 2007
On Sun, Dec 23, 2007 at 01:36:02PM +0200, Ivan Kalvachev wrote:
> On Dec 22, 2007 8:56 PM, Diego Biurrun <diego at biurrun.de> wrote:
> > I just looked at the liba52/ directory, there are two crufty files in
> > there: compare.c and test.c.
> >
> > compare.c compares two files, well diff and cmp do that as well :).
> > I'm not sure this file is worth keeping, but at least it should be moved
> > to TOOLS/. I'm tempted to remove it.
>
> It's Michael's code.
> BTW, It's not the same as diff and cmp, you can figure that even from
> the comment in the start of the file, without looking at the code :P
That's not the central point. Is the file worth keeping? If it is, we
should move it to TOOLS/, it has no business hanging around in liba52/.
> > test.c does not compile.. It must have been broken for years already so
> > nobody seems to use it. Is it worth keeping? Anybody willing to repair
> > it?
>
> Fixed, Now you have the honor to remove correctly working program.
Spare me your irony, but thanks for working constructively for a change.
Now that you fixed it I don't mind keeping it around.
Diego
More information about the MPlayer-dev-eng
mailing list