[MPlayer-dev-eng] keyboard lock PATCH [1/1]

Ulion ulion2002 at gmail.com
Sat Dec 29 15:37:50 CET 2007


2007/12/29, Peter Poulsen <peter at pgpoulsen.dk>:
> > 2007/12/29, Peter Poulsen <peter at pgpoulsen.dk>:
> >> This is my first code for MPlayer ever, so be gentle :)
> >>
> >> I have a cat that loves to step on my keyboard, and when I'm watching movies that
> >> is
> >> pretty annoying. Therefore I have made this small patch that locks the keyboard.
> >> Let
> >> me know what you think.
> >>
> >
> > By the your post title, your patch should only lock keyboard, instead
> > of other input devices. While your patch block all mplayer's commands,
> > there are quite number of commands do not come from the keyboard.
> >
> Yes, I can see that was unfortunate labeling. It should probably had been 'input
> lock' (also in the code). Any other suggestions?
>
> I have attached the modified patch.

I think keyboard lock is what you need. input lock is useless and
could cause problem, you did not block input, you did block all
commands. command is not input, even input blocked, there are still
quite number of commands need to be run.

Implement keyboard lock is not easy. If I were you, I will choose lock
input key after places where mp_input_get_cmd_from_keys get called in
input.c, only blocking single key and key value less than 0x200+128
will block all keyboard input, but possibly keep the combined key
input working (need test).


-- 
Ulion



More information about the MPlayer-dev-eng mailing list