[MPlayer-dev-eng] [PATCH] color SPU with ass (EOSD)

[Ulion]

2007/12/29, Evgeniy Stepanov <eugeni.stepanov at gmail.com>:
> Hi,
>
> I believe the colors in vobsub were fixed, do we still need to reorder them in
> vf_ass.c:333 ? Anyway, why IMGFMT_YV12 is a special case ??
>
> The amount of new code in spudec.c is frightening. It's mostly copypasted code
> for scaling images with transparency, but now it deals with colored images. I
> wonder, if the new one could also be used with grayscale images ? It could
> check if some color planes are NULL and not touch them.
>
> I've fixed some problems with sub visibility in the attached patch.

typo mistake:

+        if (vf->priv->eosd_regid == -1)
+	  eosd_unregister(vf->priv->eosd_regid);
+	vf->priv->eosd_regid=eosd_register(ass_eosd_generator, vf->priv);

I think it should be != -1 as in previous patch.
And you mixed tab in these lines, they should use space only.

-- 
Ulion