[MPlayer-dev-eng] [PATCH] fix a memleak on sub_font, it was never freed

[Guillaume LECERF]

2007/12/24, Ulion <ulion2002 at gmail.com>:
> There are more leak on the vo_font and sub_font, they'd better be
> fixed all together.
> There are two font module could using vo_font and sub_font, one for
> bitmap, one for freetype, they share same struct type font_desc_t. The
> two font module could be enabled at the same time (normal case), and
> the font load by freetype module will override font loaded by bitmap
> module without free.
> And font loaded by bitmap will not be free when freetype not enabled
> (maybe never get free since the freetype could possibly always
> override bitmap font), the free function for font_desc_t only
> available when freetype enabled, these should all be fixed.

Attached patch addresses this.
I put free_font_desc in font_load.h for it to be used on both bitmap
and freetype fonts.
It also frees sub_font (maybe this must be splitted in 2 patches?)

> When change subfont size, it reload fonts, and will not do any free
> again, etc.

load_font_ft() actually frees vo_font before reloading it. Look at
line 1102 of font_load_ft.c

-- 
Guillaume LECERF
GeeXboX developer - www.geexbox.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: font-leaks.diff
Type: text/x-diff
Size: 3311 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20071226/1cc99238/attachment.diff>