[MPlayer-dev-eng] [PATCH] vo quartz support mouse movements.

[Ulion]

2007/12/23, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
> On Sun, Dec 23, 2007 at 08:45:38PM +0800, Ulion wrote:
> > Here's a patch which make vo_quartz support send mouse movements event
> > to mplayer's command input system.
>
> The stuff setting vo_screenwidth, vo_dwidth etc. IMO does not really
> belong in this patch and should be applied separately.
> I'd actually suspect that the device_width/height variables should be
> completely replaced by vo_screenwidth/height

It indeed could be replaced, sure.
It's related with the mouse movements support, since in command.c when
handle the mouse_set_pos command, it use these vo_ variables to
calculate the mouse position in the video frame by percent expression.
Then support mouse movements does not only mean send these commands,
it also need to set those vo_ variables in correct value.
But indeed they could be split as you said, at least when commiting,
here's split patches.

-- 
Ulion
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vo_quartz_vo_variables.diff
Type: text/x-vhdl
Size: 2881 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20071223/dd855169/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vo_quartz_mouse_movements.diff
Type: text/x-vhdl
Size: 1410 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20071223/dd855169/attachment-0001.bin>