[MPlayer-dev-eng] [PATCH] Give more information about vid/aid/sid tracks in mkv container

[Reimar Döffinger]

Hello,
On Sun, Dec 16, 2007 at 12:12:07AM +1100, James . wrote:
> The following patch allows external gui's to know more about whether a track
> has the default flag set, this is very useful for gui's so that they can
> make correct decisions about which track to play:

Please attach patches (preferred, even more if you give it a proper
mime-type like text/plain) or at least make sure your mailer does not
break its lines.

>            if (mkv_d->tracks[i]->name)
>              mp_msg(MSGT_IDENTIFY, MSGL_INFO, "ID_VID_%d_NAME=%s\n", vid,
> mkv_d->tracks[i]->name);
> +
> +          if (mkv_d->tracks[i]->default_track)
> +            mp_msg(MSGT_IDENTIFY, MSGL_INFO, "ID_VID_%d_DEFAULTFLAG=1\n",
> vid);
> +          else
> +            mp_msg(MSGT_IDENTIFY, MSGL_INFO, "ID_VID_%d_DEFAULTFLAG=0\n",
> vid);
> +

mp_msg(MSGT_IDENTIFY, MSGL_INFO, "ID_VID_%d_DEFAULTFLAG=%i\n", mkv_d->tracks[i]->default_track);

seems like a simpler and easier to extend way...
And possibly all that info-printing stuff should be factored out in a
function as well instead of having mostly the same code 3 times.

Greetings,
Reimar Döffinger