[MPlayer-dev-eng] [PATCH] allow changing osd font scale independently from sub font one

Ulion ulion2002 at gmail.com
Sat Dec 22 04:09:26 CET 2007


2007/12/22, Guillaume LECERF <foxcore at gmail.com>:
> 2007/12/22, Ulion <ulion2002 at gmail.com>:
> > How about add an menu_font_scale_factor for it.
>
> If you wanna end up with 3 params, I'm fine with it, but I personally
> think that osd font size and menu font size could easily be
> correlated.
>
> > btw: I think the final change in menu.conf cmdlist probably not work,
> > since the cmdline not support property.
>
> My mistake. Patch updated.
>
> 2007/12/22, Compn <tempn at twmi.rr.com>:
> > dont forget to update the table of DOCS/tech/slave.txt
>
> Patch updated.

With your patch, the osd symbol size is bound with the charactor size
besides it (i.g. the top left osd). It's ok for the osd to me. But the
libmenu (osd menu) is not related with that osd, right? just same
names include 'osd', So I suggested give libmenu a standalone option
for that size, this will also split your patch into at least two part,
one for fix the size of charactor in osd should use osd scale factor
(in this patch libmenu can still use subtitle's factor to keep the
behavior), and another patch for add menu scale factor and menu scale
property, maybe another patch for osd scale property.

in the slave.txt, you need to check the bottom of that file, should
also add one line for it.

-- 
Ulion



More information about the MPlayer-dev-eng mailing list